Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Lens function references shouldn't include the function definition #856

Closed
mattmcnabb opened this issue Jun 10, 2017 · 2 comments
Closed

Code Lens function references shouldn't include the function definition #856

mattmcnabb opened this issue Jun 10, 2017 · 2 comments
Labels
Area-Pester Issue-Bug A bug to squash.
Milestone
1.3.2

Comments

@mattmcnabb
Copy link
Contributor

The new feature in v1.3.0 displays any references in a workspace for functions. These references always have a count of at least 1 because it includes the function definition in the references. Please consider referencing only the calls to the defined function, not the definition itself. This offers a more useful count.

image
@daviwil
Copy link
Contributor

daviwil commented Jun 10, 2017

Good catch! I'll get it fixed in the next release.

@daviwil daviwil added Area-Pester Issue-Bug A bug to squash. labels Jun 10, 2017
@daviwil daviwil modified the milestones: June 2017, 1.3.2 Jun 10, 2017
@daviwil
Copy link
Contributor

daviwil commented Jun 12, 2017

Fixed by this commit: PowerShell/PowerShellEditorServices@393d4dd

Forgot to add it to the commit message :)

@daviwil daviwil closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Pester Issue-Bug A bug to squash.
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
2 participants
@daviwil @mattmcnabb