Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write-VSCodeHtmlContentView AppendBodyContent should accept pipeline input #909

Closed
stefanstranger opened this issue Jun 22, 2017 · 2 comments
Labels
Area-HTML Content View Issue-Enhancement A feature request (enhancement).

Comments

@stefanstranger
Copy link
Contributor

System Details

  • Operating system name and version: Windows 7
  • VS Code version: 1.13.1
  • PowerShell extension version: 1.4.0
  • Output from $PSVersionTable:

Name Value


PSVersion 5.0.10586.117
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.10586.117
CLRVersion 4.0.30319.18063
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Copy / paste the below commands into the PowerShell Integrated Terminal, and paste the output here

1.13.1
379d2efb5539b09112c793d3d9a413017d736f89
ms-vscode.PowerShell@1.4.0

Name                           Value                                                                            
----                           -----                                                                            
PSVersion                      5.0.10586.117                                                                    
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                          
BuildVersion                   10.0.10586.117                                                                   
CLRVersion                     4.0.30319.18063                                                                  
WSManStackVersion              3.0                                                                              
PSRemotingProtocolVersion      2.3                                                                              
SerializationVersion           1.1.0.1  

Issue Description

When using the new Write-VSCodeHtmlContenView cmdlet the parameter AppendBodyContext does not accept input from the pipeline.

get-command Write-VSCodeHtmlContentView -syntax

Write-VSCodeHtmlContentView [-HtmlContentView] [-AppendedHtmlBodyContent] []

Would it not be possible to use an object from Convertto-HTML as input for this Cmdlet directly via the Pipeline?

Example feature request:
Get-Service | Select Name, Status | Write-VSCodeHtmlContentView -View $View

Attached Logs

Not applicable

@daviwil daviwil changed the title Write-VSCodeHtmlContentView appendbodycontent as pipeline input Write-VSCodeHtmlContentView AppendBodyContent should accept pipeline input Jun 22, 2017
@daviwil daviwil added Area-HTML Content View Issue-Enhancement A feature request (enhancement). labels Jun 22, 2017
@daviwil daviwil added this to the July 2017 milestone Jun 22, 2017
@daviwil
Copy link
Contributor

daviwil commented Jun 22, 2017

Looks like Write-Host -Object accepts input from the pipeline so I'll make the Write-VSCodeHtmlContentView follow that same standard. Thanks Stefan!

@stefanstranger
Copy link
Contributor Author

Thank you David.

daviwil added a commit to daviwil/PowerShellEditorServices that referenced this issue Jul 11, 2017
This change adds the ValueFromPipeline setting to the
AppendedHtmlBodyContent parameter of the Write-VSCodeHtmlContentView
cmdlet so that pipeline output can be written out to an HtmlContentView
with ease.

Resolves PowerShell/vscode-powershell#909.
daviwil added a commit to PowerShell/PowerShellEditorServices that referenced this issue Jul 11, 2017
This change adds the ValueFromPipeline setting to the
AppendedHtmlBodyContent parameter of the Write-VSCodeHtmlContentView
cmdlet so that pipeline output can be written out to an HtmlContentView
with ease.

Resolves PowerShell/vscode-powershell#909.
@daviwil daviwil modified the milestones: July 2017, 1.5.0 Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-HTML Content View Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

2 participants