Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new vscode-command : PowerShell.InvokeRegisteredEditorCommand #917

Closed
kamilkosek opened this issue Jun 22, 2017 · 4 comments
Closed
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@kamilkosek
Copy link
Contributor

kamilkosek commented Jun 22, 2017

Changes are very simple , but for now it´s enough to play around 😄
https://github.com/kamilkosek/vscode-powershell/tree/HTMLContentViewPlayground
Test Script
Note: This only works if the content view accepts JavaScript

@daviwil
Copy link
Contributor

daviwil commented Jun 23, 2017

Would you like to send the InvokeRegisteredEditorCommand as a PR too? If you can leave the JavaScript enabling commit out then I'll add that part next week :)

@daviwil daviwil added Area-General Issue-Enhancement A feature request (enhancement). labels Jun 23, 2017
@daviwil daviwil added this to the June 2017 milestone Jun 23, 2017
@kamilkosek
Copy link
Contributor Author

kamilkosek commented Jun 23, 2017

Sure, but since I´m new to 'Contributing to public GitHub Repo´s' i need to figure out how to leave that commit out 😆

@kamilkosek
Copy link
Contributor Author

Maybe we will have someday a convenient way to achieve something like this:
20170623_162522

I ❤️ GIF´s

@daviwil
Copy link
Contributor

daviwil commented Jun 23, 2017

Love the GIF! Really cool to see everything hooked up end to end. We can definitely look for ways to make it easier to build tool UIs, the PowerShellEditorServices.VSCode module might be a good place for that.

Fixed with PR #919

@daviwil daviwil closed this as completed Jun 23, 2017
@daviwil daviwil modified the milestones: June 2017, July 2017 Jul 11, 2017
@daviwil daviwil modified the milestones: July 2017, 1.5.0 Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

2 participants