Skip to content

Check for the expected version of the PowerShell Editor Services module fails because of the wrong function parameters #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

ant-druha
Copy link

'Test-ModuleAvailable' function does not have -RequiredVersion parameter, hence the script fails to evaluate the condition (at least for PS version 3.0.1).

@rkeithhill rkeithhill requested a review from daviwil January 12, 2018 17:17
@rkeithhill
Copy link
Contributor

rkeithhill commented Jan 12, 2018

Seems like a legit issue / fix. 👍 Thanks!

@daviwil
Copy link
Contributor

daviwil commented Jan 12, 2018

Thanks for the PR! I wonder if this might cause PSES modules not of that exact version to be loaded on PS5 if the behavior somehow differs after the RequiredVersion parameter was introduced.

@daviwil
Copy link
Contributor

daviwil commented Jan 12, 2018

I'll merge it for now since if nothing else, it impacts PSv3 users.

@daviwil daviwil merged commit ad0bd24 into PowerShell:master Jan 12, 2018
@ant-druha ant-druha deleted the vscode-powershell-adernov branch January 13, 2018 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants