-
Notifications
You must be signed in to change notification settings - Fork 512
Set createTempIntCon when creating launch config for Pester test #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -47,6 +49,7 @@ export class PesterTestsFeature implements IFeature { | |||
], | |||
internalConsoleOptions: "neverOpen", | |||
noDebug: !runInDebugger, | |||
createTemporaryIntegratedConsole: settings.debugging.createTemporaryIntegratedConsole, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the setting only be used when runInDebugger is true? I could go either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is benefit in being able to run tests in a fresh session. Yeah, the [DGB]
in the terminal name is bit of a misnomer in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe if "runInDebugger" is false we can use a different title? That was short-sighted on my part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe [TMP] PowerShell Integrated Console
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or [TEMP]
just to be extra clear, but anything works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the same comment David has :)
Which specific comment? Right now, the behavior is that whether you are running Pester tests or debugging, if |
Oh sorry, the comment on changing |
Thanks. Just pushed that change so I'll go ahead and merge this. |
Fixes #1208