Skip to content

Set createTempIntCon when creating launch config for Pester test #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Feb 23, 2018

Fixes #1208

@rkeithhill rkeithhill changed the title Set createTempIntCon when createing launch config for Pester test Set createTempIntCon when creating launch config for Pester test Feb 23, 2018
@@ -47,6 +49,7 @@ export class PesterTestsFeature implements IFeature {
],
internalConsoleOptions: "neverOpen",
noDebug: !runInDebugger,
createTemporaryIntegratedConsole: settings.debugging.createTemporaryIntegratedConsole,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the setting only be used when runInDebugger is true? I could go either way

Copy link
Contributor Author

@rkeithhill rkeithhill Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is benefit in being able to run tests in a fresh session. Yeah, the [DGB] in the terminal name is bit of a misnomer in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if "runInDebugger" is false we can use a different title? That was short-sighted on my part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe [TMP] PowerShell Integrated Console ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or [TEMP] just to be extra clear, but anything works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish the VSCode folks would make this dropdown a tad wider:
image
What do you think?

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same comment David has :)

@rkeithhill
Copy link
Contributor Author

Which specific comment?

Right now, the behavior is that whether you are running Pester tests or debugging, if powershell.debugging.createTemporaryIntegratedConsole is set to true, either of these operations happen in the terminal window [TEMP] PowerShell Integrated Console. That terminal window sticks around until the next Pester test run or debug session at which time the existing PowerShell process is closed and recreated, attached to a new VSCode terminal window with the exact same name. [TEMP] PowerShell Integrated Console is effectively the one and only terminal window for "powershell.debugging.createTemporaryIntegratedConsole": true even though the associated PowerShell process changes with each run. I think that is what we want but if not, let me know.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 28, 2018

Oh sorry, the comment on changing dbg to temp

@rkeithhill
Copy link
Contributor Author

Thanks. Just pushed that change so I'll go ahead and merge this.

@rkeithhill rkeithhill merged commit 4383b3a into master Feb 28, 2018
@rkeithhill rkeithhill added this to the 1.6.1 milestone Mar 10, 2018
@rkeithhill rkeithhill deleted the rkeithhill/fix-1208-dgb-pester-temp branch April 1, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants