Skip to content

Remove Start-EditorServices and put in PSES repo #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Mar 21, 2018

The Start-EditorServices script belongs to PowerShellEditorServices, so should be moved back there. This PR just makes that change.

Adding the script into PSES is tracked in PSES PR #639.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to update the code to use the correct path of the Start-EditorServices.ps1.

Right now, Start-EditorServices.ps1 doesn't get published inside of vscode-powershell/modules/PowerShellEditorServices.

We should consider adding it in there so that we can use that path in vscode-powershell. I think this requires modifying the PSES build script to add the Start-EditorServices file to it's module.

@rjmholt
Copy link
Contributor Author

rjmholt commented Mar 22, 2018

So the path here needs to be ..\..\modules\PowerShellEditorServices\module\Start-EditorServices.ps1?

@TylerLeonhardt
Copy link
Member

That looks right. Keep in mind, we may need to do some work to the build script because as of right now, I don't think that file gets copied over to the path you mentioned and while developing I believe the extension uses the PSES folder that you cloned next to the vscode-powershell folder.

Now I'm starting to realize why David did this in the first place 😅

@rjmholt
Copy link
Contributor Author

rjmholt commented Apr 4, 2018

Not sure how I managed to double up on PRs here (I think?). Closing in favour of #1252.

@rjmholt rjmholt closed this Apr 4, 2018
@rjmholt rjmholt deleted the remove-startpses-script branch December 11, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants