Change SpecifyScriptArgs command to only return string - not string[] #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PowerShell#1315 but folks won't see this fix until they are on VSCode 1.24 or insiders build >= 5/11. This is because a corresponding fix is required in VSCode.
TylerLeonhardt
approved these changes
May 12, 2018
|
Yup, VSCode 1.11 (and earlier) had a bug so we had code to avoid that bug. Our min version for VSCode has surpassed 1.11 for some time now so I took the opportunity to remove that unnecessary code. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1315 but folks won't see this fix until they are on VSCode 1.24
or insiders build >= 5/11.
This is because a corresponding fix is required in VSCode.