WIP attempt to fix code folding provider in VSCode 1.25 #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging issue was elsewhere. I submitted a different PR to fix it.
|
Note that it builds successfully because I switched from the "removed" method to use the new method. Unfortunately, I'm not using the new method hard enough because it's not getting back an IGrammar object. |
3 tasks
|
The idea looks good! |
|
One issue is now we either have to require VSCode 1.25 or we have conditional code for <= 1.24 and >= 1.25. |
|
Yeah I thought that too.... Ideally branching on the major version of the vscode-textmate module |
|
@rkeithhill I've put up my own version of your PR at #1414 |
|
Going with @glennsarti PR #1414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
VSCode 1.25 updated its
vscode-textmatenpm module from v3.3.3 to v4. In the process, that module removed a method we relied upon. I've substituted in the new method but it isn't working right.I also added an ILogger interface to make the MockLogger easier to implement and hopefully make the tests a bit more reliable.
@glennsarti could you please take a look at this. Feel free to checkout this branch and update it.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready