Turn powershell.codeformatting.useCorrectCasing setting off by default until PSSA issues are fixed #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t until PSSA issues are fixed
|
I wonder if in a separate PR we should correct the casing on these two settings? If we are going to correct this, probably better to do it sooner before more folks customize these settings. |
|
Yes, since the settings are new, the likelihood that people already use them is low, the release blog post mentions them though. |
rjmholt
approved these changes
Apr 8, 2019
bergmeister
added a commit
to bergmeister/vscode-powershell
that referenced
this pull request
Apr 9, 2019
…t until PSSA issues are fixed (PowerShell#1852)
rjmholt
pushed a commit
to rjmholt/vscode-powershell
that referenced
this pull request
Apr 10, 2019
…t until PSSA issues are fixed (PowerShell#1852)
rjmholt
pushed a commit
that referenced
this pull request
Apr 10, 2019
…t until PSSA issues are fixed (#1852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Due to the following formattig PSSA issues it's probably better to not enable the setting by default until a patch of PSSA is available (we could also do this only for version 1 of the extension but I am currently targeting master, it is up to you and the preferred timeline of next extension or PSSA release)
Alias "?" is changed to "%" by Invoke-Formatter: Alias "?" is changed to "%" by Invoke-Formatter PSScriptAnalyzer#1209Cmdlet aliases are expanded automatically when formatting document: Cmdlet aliases are expanded automatically when formatting document #1842gitget corrected togit.exe(which would make a script not cross-platform any more): How to prevent code formatting "findstr--->findstr.exe" #1849Note that this requires the following PSES PR because the vscode extension setting was not actually used by PSES: PowerShell/PowerShellEditorServices#910
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready