Set Default PowerShell Version on Windows to Latest Available

[SydneyhSmith]

PR Summary

Updated the default PowerShell path on Windows to check for the latest version (previous behavior defaulted to Windows PowerShell). Also removed an SSL check that is no longer necessary.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

• PR has a meaningful title
• Summarized changes
• PR has tests
• This PR is ready to merge and is not work in progress
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

[SydneyhSmith]

Looks like the error might be a result of the intended design-- the default PowerShell path is no longer Windows (as previously expected)

[bergmeister]

This makes the assumption that the user has chosen the default MSI installation path. Ideally we should query the registry for it. However, currently the installer does not create a registry key for it, so we can't do that now. Going forward we should fix that though using something like this: https://stackoverflow.com/a/13451210/1810304
cc @TravisEz13

[TylerLeonhardt]

Is it not here, in the registry @bergmeister?:

https://github.com/microsoft/vscode/blob/ffcb9e62b4365e652caeb05c80d4d7582833fdb8/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts#L120-L139

[corbob]

Is it not here, in the registry @bergmeister?:

https://github.com/microsoft/vscode/blob/ffcb9e62b4365e652caeb05c80d4d7582833fdb8/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts#L120-L139

Well that explains why Win+R > pwsh launches a different pwsh than cmd > pwsh. Windows Run looks to App Paths before it looks to the Path variable, and so it's launching 7 Preview for me, while cmd looks to the path only and thus launches 6.2.2.

I believe what @bergmeister is referring to is the InstallLocation value in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{A55D1349-D294-43E8-B79A-1EC86DC3D18A} for 6.2.2, and Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{EA126E54-972B-4EC0-A823-5D37B1284BCE} for 7.0-preview. Personally the InstallLocation is where I would expect to find where the path actually is, but then you might need to maintain a list of GUIDs for each version?

[TylerLeonhardt]

Yeah that makes sense - I think we should default to the install location (what Sydney already has) rather than switch to the App Paths.

[rkeithhill]

Minor-nit but to maintain the coding style this line and line 81 should be indented four more spaces.

[bergmeister]

Is it not here, in the registry @bergmeister?:

https://github.com/microsoft/vscode/blob/ffcb9e62b4365e652caeb05c80d4d7582833fdb8/src/vs/workbench/contrib/terminal/electron-browser/terminalService.ts#L120-L139

Oh, I forgot we had this one as well. Normally apps, register a key for the uninstall location but the one that you references is perfectly fine and does the job as well :-)
From a standardization perspective, people would still expect to find the InstallLocation registry key as most (>50% of installers do), therefore I'd still recommend the PS installer to do that because people usually do something like this: https://stackoverflow.com/a/55229210/1810304

[TylerLeonhardt]

LGTM - just a single comment addition