Don't scan node_modules for secrets during release #2260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Oct 29, 2019
rjmholt
approved these changes
Oct 29, 2019
|
@TravisEz13 can I get your feedback on this? |
TylerLeonhardt
force-pushed
the
add-cred-scan-suppression
branch
from
306815d to
d08b197
Compare
TylerLeonhardt
changed the title
TylerLeonhardt
changed the title
TravisEz13
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
CredScan was complaining because a node_module that we pull in had some test pem's in their package. This was only occurring in the release build because CredScan happens after the build in that.
This PR creates a tsv with all the files we want to scan (excluding
node_modules) and then gives that to the CredScan task since the CredScan executable cannot take multiple inputs...PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready