Skip to content

Fix duplicated command registrations #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021
Merged

Fix duplicated command registrations #3329

merged 2 commits into from
May 3, 2021

Conversation

MartinGC94
Copy link
Contributor

PR Summary

Fixes #3320 by adding extension commands that call the built-in commands.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ghost ghost added Area-UI Issue-Bug A bug to squash. labels May 2, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the goal here:

The purpose of my change was to add buttons for those built-in actions because people who are used to ISE are used to having buttons for moving the console around.

I think this PR is a good fix to keep that goal satisfied, I left commit-able suggestions to fix the casing of PowerShell for consistency.

Co-authored-by: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@andyleejordan andyleejordan merged commit 44d8f40 into PowerShell:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate commands registered
2 participants