Skip to content

Add multi-root choice experience to powershell.cwd #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Conversation

andyleejordan
Copy link
Member

Client-side changes related to PowerShell/PowerShellEditorServices#1849, we should be validating powershell.cwd. Part of #2153, we need to handle if the opened workspace has multiple folders.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Configuration labels Jul 7, 2022
@andyleejordan andyleejordan requested a review from a team July 7, 2022 16:13
@andyleejordan andyleejordan force-pushed the andschwa/cwd branch 2 times, most recently from 0728dc8 to cab3a2f Compare July 11, 2022 23:28
@andyleejordan andyleejordan changed the title WIP: Add multi-root choice experience to powershell.cwd Add multi-root choice experience to powershell.cwd Jul 11, 2022
@andyleejordan
Copy link
Member Author

@SeeminglyScience no longer WIP!

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andyleejordan and others added 2 commits July 12, 2022 15:43
@andyleejordan
Copy link
Member Author

Whoops, meant to merge this first, oh well it's fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants