Rename "Integrated Console" to "Extension Terminal" #4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically we drop "Terminal" for the title in the terminals pane as that's redundant (and too long for a narrow view). We switching to "terminal" from "console" to align with VS Code's terminology, and "PowerShell Extension Terminal" is what was decided in the RFC through community feedback.
ghost
added
Area-Extension Terminal
Issue-Enhancement
|
@JustinGrote did I miss anything? |
|
@andschwa the most visible occurances of it are covered at least, LGTM |
andyleejordan
commented
Jul 25, 2022
| @@ -82,7 +82,7 @@ function Get-Bullets { | |||
| 'Area-Documentation' = '📖' | |||
| 'Area-Engine' = '🚂' | |||
| 'Area-Folding' = '📚' | |||
| 'Area-Integrated Console' = '📟' | |||
| 'Area-Extension Terminal' = '📟' | |||
There was a problem hiding this comment.
I renamed the labels on GitHub too.
There was a problem hiding this comment.
You think of everything!
andyleejordan
commented
Jul 25, 2022
| @@ -477,7 +481,7 @@ export class SessionManager implements Middleware { | |||
| new PowerShellProcess( | |||
| this.PowerShellExeDetails.exePath, | |||
| this.bundledModulesPath, | |||
| "PowerShell Integrated Console", | |||
| "PowerShell Extension", | |||
There was a problem hiding this comment.
Explicitly no "Terminal" addendum because this is what's displayed in the list of terminals.
andyleejordan
commented
Jul 25, 2022
SydneyhSmith
approved these changes
Jul 25, 2022
Truly I just didn't like the ASCII arrows.
andyleejordan
force-pushed
the
andschwa/rename-terminal
branch
from
8d2cf9d to
765f658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4053.