Skip to content

Guard -WaitForDebugger flag client-side too #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export class SessionManager implements Middleware {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if ((resolvedCodeLens as Thenable<vscode.CodeLens>).then) {
return (resolvedCodeLens as Thenable<vscode.CodeLens>).then(resolveFunc);
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
} else if (resolvedCodeLens as vscode.CodeLens) {
return resolveFunc(resolvedCodeLens as vscode.CodeLens);
}
Expand Down Expand Up @@ -571,7 +571,9 @@ Type 'help' to get help.
editorServicesArgs += `-StartupBanner "${startupBanner}" `;
}

if (this.sessionSettings.developer.editorServicesWaitForDebugger) {
// We guard this here too out of an abundance of precaution.
if (this.sessionSettings.developer.editorServicesWaitForDebugger
&& this.extensionContext.extensionMode === vscode.ExtensionMode.Development) {
editorServicesArgs += "-WaitForDebugger ";
}

Expand Down