Skip to content

Fix @vscode/vsce dependency after its rename #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

andyleejordan
Copy link
Member

Also fix the documentation to recommend Node v16, as that's what VS Code currently uses, and v14 is too old for dependencies such as @vscode/test-electron, and the badge links in the readme since the upstream URL changed without notice.

This should fix the release process so we can get another preview out.

Also fix the documentation to recommend Node v16, as that's what VS Code
currently uses, and v14 is too old for dependencies such as
`@vscode/test-electron`, and the badge links in the readme since the
upstream URL changed without notice.

This should fix the release process.
@andyleejordan andyleejordan requested a review from a team January 3, 2023 19:13
@andyleejordan andyleejordan requested a review from a team as a code owner January 3, 2023 19:13
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) January 3, 2023 19:16
@andyleejordan andyleejordan merged commit 4414185 into main Jan 3, 2023
@andyleejordan andyleejordan deleted the andschwa/vsce branch January 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants