Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump packages #5061

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Bump packages #5061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73ff73a
Remove superfluous activation events
andyleejordan Oct 10, 2024
2faa9a1
Bump engine and Node.js
andyleejordan Oct 10, 2024
f144397
Bump Node.js packages
andyleejordan Oct 10, 2024
180dacf
Bump VS Code and Node types
andyleejordan Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@
## Tracking Upstream Dependencies

As a VS Code extension, we first rely on the `engine` field of `package.json` to
state the lowest version of VS Code we support. This extension in particular
must not update past what Azure Data Studio supports, which can be found in the
[`vscodeVersion`][] field of their `product.json` file. We periodically check
that for updates, and when available update our own.
state the lowest version of VS Code we support.

When our `engine` field is updated the development dependency `@types/vscode`
must be updated to match. Note that it uses `~` (not `^`) so as to accept new
Expand All @@ -40,8 +37,8 @@ lets us finally update our `@types/node` development dependency to match, our
developer machines if necessary, and the CI and OneBranch pipeline tasks.

[`vscodeVersion`]: https://github.com/microsoft/azuredatastudio/blob/4970733324ef8254b7c22a5dc55af7f8a1dea93f/product.json#L50
[`electron`]: https://github.com/microsoft/vscode/blob/8b617bd08fd9e3fc94d14adb8d358b56e3f72314/package.json#L153
[Electron]: https://www.electronjs.org/blog/electron-25-0
[`electron`]: https://github.com/microsoft/vscode/blob/384ff7382de624fb94dbaf6da11977bba1ecd427/package.json#L159
[Electron]: https://www.electronjs.org/blog/electron-30-0
[Node.js]: https://nodejs.org/en/download/package-manager

### Building the Code
Expand Down
Loading