Allow inclusion of JavaScript and CSS file paths in the HtmlContentView #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the client-side behavior for new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Resolves PowerShell#910.
|
I was just wondering what the nonce is for 😃 BTW, any plans on parameter passing from content-view to editor command ? |
|
Yep, the nonce helps avoid malicious JS and CSS being loaded into the user's browser. You could say that someone would just as easily be able to use these new parameters to load malicious scripts but it does give us the capability to further restrict their use from within PowerShell depending on the machine's security settings. I think the only thing needed for that right now is allowing parameters to be send to registered editor commands via the protocol. I'll look into it for this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the client-side behavior for new parameters to
Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths
and StyleSheetPaths to include local JavaScript and CSS files into their
HTML views.
Resolves #910.