Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Prompt is not working properly #487

Closed
maddie opened this issue Apr 19, 2017 · 13 comments
Closed

Prompt is not working properly #487

maddie opened this issue Apr 19, 2017 · 13 comments
Assignees

Comments

@maddie
Copy link

maddie commented Apr 19, 2017

nerdfont-complete mode, installed with Prezto.

It looks like this with latest commit:

$(print_icon MULTILINE_SECOND_PROMPT_PREFIX)                                            $RPROMPT_PREFIX$(build_right_prompt)$reset_color$RPROMPT_SUFFIX

After reverting to 01a5c6a the prompt is normal again..

@qifei9
Copy link

qifei9 commented Apr 19, 2017

I meet the same issue, with awesome-patched mode.

@bhilburn
Copy link
Member

@maddie @qifei9 - Thanks for reporting this! I merged #486 to fix a security bug in #445, which looks like it may have broken something?

@maddie @qifei9 - Just to double-check:

  1. You are using Prezto
  2. You are using multi-lined prompt
  3. You are using nerdfont-complete

My guess is that only #2 matters, but I want to confirm.

We'll want to move quickly to fix this since it is in master. Simply reverting the merge isn't a great option, as that re-introduces the security issue.

@belak - Any input here would be awesome. @dritter your feedback will be important, as well.

@strayer
Copy link

strayer commented Apr 19, 2017

I have the same issue. Using powerlevel9k directly with zplug, no special fonts either. I do have a multi-lined prompt though. Went back to 37174ea for now.

@qifei9
Copy link

qifei9 commented Apr 19, 2017

@bhilburn

  • I use zplug
  • I use multi-lined prompt, but this issue also occurs in single-lined prompt
  • I use awesome-patched

@bhilburn
Copy link
Member

@maddie @strayer @qifei9 - Thanks for the comments. I have reverted the merge commit. Please checkout the HEAD of master and confirm that it's now working?

@belak @dritter - Reopening #486 so we can continue the discussion there.

@qifei9
Copy link

qifei9 commented Apr 19, 2017

@bhilburn
It works at 99e59bc (current HEAD of master) and 01a5c6a.
The issue occurs at 2817b45 and ae259ff.

@bhilburn
Copy link
Member

@qifei9 - Thanks for confirming!

I'd like to get one more confirmation that HEAD is now fixed. @strayer, @maddie - Can you test & confirm as soon as you get the chance?

@strayer
Copy link

strayer commented Apr 19, 2017

Master seems to work fine for me now on three machines, thanks for the quick fix!

@bhilburn
Copy link
Member

@strayer - Thanks for the confirmation! I really appreciate it.

@maddie - Go ahead and update to the latest master and you should be good. Thanks again for reporting.

Resolving #445 in a way that doesn't break things is being discussed in #491 for anyone interested.

@wadkar
Copy link
Contributor

wadkar commented Apr 19, 2017

Thanks @bhilburn for the update; I usually run off next branch, and that clearly has this issue. I am working off master for now.

Happy to help test out #491 !

@bhilburn
Copy link
Member

@wadkar - I merged the fix into next, as well, so you should be good =)

@j0hnm4r5
Copy link

j0hnm4r5 commented Feb 2, 2018

I've been getting this issue as well, even with an up-to-date commit: d4a3c04. When doing a quick control-c on a prompt (or multiple times in quick succession), I'll get $RPROMPT_PREFIX$(build_right_prompt)$reset_color$RPROMPT_SUFFIX instead of my regular prompt.

Using POWERLEVEL9K_MODE='awesome-patched' on Oh My Zsh.

@Elaniobro
Copy link

@j0hnm4r5 I am seeing the same thing when I ctrl + c

~/.zshrc:

POWERLEVEL9K_MODE='awesome-fontconfig'
ZSH_THEME="powerlevel9k/powerlevel9k"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants