Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

[Bugfix] Update VIRTUAL_ENV_DISABLE_PROMPT value #1079

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

josselinauguste
Copy link
Contributor

Following a prezto update, the flag value of the VIRTUAL_ENV_DISABLE_PROMPT variable is now 12 (https://github.com/sorin-ionescu/prezto/blob/e9387a177e04b05dcf4f82e622615ddd32c558db/modules/python/init.zsh#L103).

@dritter
Copy link
Member

dritter commented Nov 18, 2018

Hi @josselinauguste , thanks for this PR. TBH, I don't know if this is right or not. The relevant commit in prezto is sorin-ionescu/prezto@ee885d4 and they reference this change in pure sindresorhus/pure@afa625b .

Why don't we just check if VIRTUAL_ENV_DISABLE_PROMPT is not empty? That would work with any value. On the downside this would disable the segment, even if the value would be set to false.. But to me it seems better than checking magic values..

@josselinauguste
Copy link
Contributor Author

TBH, I don't know neither :-) The only thing I know is that the previous version didn't work, and this one does work.

I'm gonna try by checking if it's empty.

@josselinauguste
Copy link
Contributor Author

It seems to work, the PR is updated!

@bhilburn
Copy link
Member

Great recommendation, @dritter!

@josselinauguste - Thanks for putting together this PR and iterating on it with @dritter! This is a great first contribution to P9k - welcome to the project! =)

@bhilburn bhilburn merged commit 2f4b150 into Powerlevel9k:master Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants