Add out of bounds check for encoding/decoding #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dngrudin
force-pushed
the
buffer-overflow-check
branch
4 times, most recently
from
c4fe3ae to
c31559c
Compare
|
Thank you for your great work! I'll take a review this week. |
PragmaTwice
reviewed
Nov 22, 2024
PragmaTwice
reviewed
Nov 22, 2024
dngrudin
force-pushed
the
buffer-overflow-check
branch
5 times, most recently
from
aa4fd38 to
6942b30
Compare
PragmaTwice
reviewed
Nov 27, 2024
include/protopuf/coder_mode.h
Outdated
There was a problem hiding this comment.
Wow the abstraction over "mode" looks great!
dngrudin
force-pushed
the
buffer-overflow-check
branch
from
6942b30 to
426473d
Compare
PragmaTwice
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to select the encoding/decoding mode. If the safe mode is selected, then the buffer is checked for going beyond the boundaries. In this mode, the result is wrapped in std::optional.
In the unsafe mode (which is selected by default), no checks are performed. The encoding result is similar to what it was before the changes.
The decoding result is almost compatible with what it was before the changes (when assigning the result to a variable with the type 'auto', nothing in the old code will need to be changed).
Also the code is prepared for compilation with the flags -Wall -Werror -Wextra -Wconversion -pedantic.