Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build.yml #95

Closed
3 of 4 tasks
DannyDarwiche opened this issue Jul 29, 2021 · 0 comments · Fixed by #117
Closed
3 of 4 tasks

Refactor build.yml #95

DannyDarwiche opened this issue Jul 29, 2021 · 0 comments · Fixed by #117

Comments

@DannyDarwiche
Copy link
Collaborator

DannyDarwiche commented Jul 29, 2021

Definition of done

  • (Windows) Executable file has .exe extension in filename
  • (Mac) Override.cfg file is placed in the same directory as the project binary
  • (All) Run GUT tests through command line
  • (All) Build with command line instead of action
DannyDarwiche added a commit that referenced this issue Aug 4, 2021
Uses a container with Godot in order to build the client and run the tests from the command line instead of using github actions
Windows executable built with .exe in name
Change underscore to dash in project zip name

Fixes #95 > Quality of Life: Windows build now comes as an executable file
DannyDarwiche added a commit that referenced this issue Aug 4, 2021
Uses a container with Godot in order to build the client and run the tests from the command line instead of using github actions
Windows executable built with .exe in name
Change underscore to dash in project zip name

Fixes #95 > Quality of Life: Windows build now comes as an executable file
DannyDarwiche added a commit that referenced this issue Aug 4, 2021
Uses a container with Godot in order to build the client and run the tests from the command line instead of using github actions
Windows executable built with .exe in name
Change underscore to dash in project zip name

Fixes #95 > Quality of Life: Windows build now comes as an executable file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant