-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DramaCool): add watchasia.to domain #8877
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add 'watchasia.to' please. it's another domain of dramacool, i think it myt be the original because it's easier to find drama names there unlike the dramacool.vc one. THnak u Signed-off-by: Zukuchi <97039022+Zukuchi@users.noreply.github.com>
theusaf
requested changes
Nov 11, 2024
@@ -11,6 +11,7 @@ | |||
"nl": "Dramacool - Bekijk Aziatische drama's, films en shows met Engelse ondertiteling op Dramacool in Full HD Gratis. Een coole site voor grote mensen." | |||
}, | |||
"url": "dramacool.vc", | |||
"url": "watchasia.to", | |||
"regExp": "[0-9w]{0,6}.*dramacool.[a-z]+", | |||
"version": "1.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"version": "1.3.0", | |
"version": "1.4.0", |
theusaf
changed the title
Update metadata.json (ANOTHER DOMAIN)
fix(DramaCool): add watchasia.to domain
Nov 11, 2024
theusaf
changed the title
fix(DramaCool): add watchasia.to domain
feat(DramaCool): add watchasia.to domain
Nov 11, 2024
Consider also adding the domain from #8723 too |
theusaf
added
the
inactive
PR has been inactive for a while and will be closed soon
label
Nov 15, 2024
Comment on lines
13
to
+14
"url": "dramacool.vc", | ||
"url": "watchasia.to", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh
Closing for inactivity. You can open a new PR after resolving existing conversatoins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 'watchasia.to' please. it's another domain of dramacool, i think it myt be the original because it's easier to find drama names there unlike the dramacool.vc one. Thank you
(also, i dont know how to code so I just put it like that but anyways, yeah)
Description
Acknowledgements
yarn format
Screenshots
Proof showing the creation/modification is working as expected