feat(RTLplay): revamp 2.0.0 + features added

[pierrequiroul]

Description

Added features :

• now displays radio bel rtl (from the same tv group)
• now correctly displays the new RTL district channel
• getThumbnail updated to give images a better gradient border
• new icons (including vinyl for music)
• changes to the way information is displayed (formatting)
• slideshow on media page between poster and background image

Changes/fixes/qol:

• displays new timestamps correctly
• moved utilities functions to a separate file
• renamed presence parameters to make them clearer to understand (avoid typos by using them, especially for me lol)
• reorganized tags to display the 3 most relevant ones first (for the visual of the new extension)
• added functions getLocalizedAssets (for the ad icon), limitText (largeImageText has a limit of 128 characters)
• added crop presets for the getThumbnail function (to modify values in a single location)
• fixed the search page

So, with all that, I modified the version from 1.0.3 to 2.0.0

Previous look:
#8605

Acknowledgements

• I read the Presence Guidelines
• I linted the code by running yarn format
• The PR title follows the repo's commit conventions

Screenshots

Proof showing the creation/modification is working as expected

https://imgur.com/a/vFVSzog

Home page:

Search page:


Media page



Watching a TV Show (usePresenceName setting)


Watching a livestream


Radio livestream (music clip channel)

Regular radio player (bel rtl and radio contact websites)

[Bas950]

this shouldn't be needed anymore.

[pierrequiroul]

Hi @Bas950 !
I wanted to add the features keeping in mind that it works correctly on older versions too. I noticed that with Version: 2.7.0 (ba99913), when a media is played, the extension spammed headless_sessions in the service worker because the start timestamp was updated too fast, resulting in a lot of headless_sessions failing in rate limited. This meant that the change to other pages was much less responsive or was blocking or taking a long time because I guess there's probably a queue set up for status discord changes. So I looked at how other presences handled timestamps, found this function and it solved the problem. The headless_sessions stabilize after a while and only send when necessary, and the page change is more responsive.

I also tested with the latest recoded build Version: 2.7.0 (e9ff721) if this problem existed and it doesn't. So I agree with you and I came to the conclusion that this function was temporary and could be removed in the future. During development I went back and forth between the 2 versions to see if everything worked as I imagined it would in both.

With adjust function

Without

[Bas950]

@Timeraa might be able to confirm, but I don't think we will release these presences to the current bundled extension version. So it will be released with the new alpha/beta version.

[Timeraa]

I'm not quite sure, I hope to finish 2.7.0 this year but no promises there but the spamming issue still somewhat happens with that function on 2.6.x because of a broken if check

[pierrequiroul]

@Bas950 @theusaf, I removed the adjustTimeError function as requested.
I also added altnames and new tags in the metadata.json since your last reviews because TV Channels and Radio could be interpreted as different services on their own (I doubt but who knows)

Changes were made