Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static representation of RS Component "matching" not working in task #2263

Open
dbrianwalton opened this issue Oct 2, 2024 · 3 comments
Open

Comments

@dbrianwalton
Copy link
Contributor

The tables that should appear in a static representation for "matching" problems are not generated when in anything other than exercise. The relevant templates appear in pretext/xsl/pretext-runestone-static.xsl:

<xsl:template match="exercise/matches/match" mode="matching-statement">
<xsl:template match="exercise/matches/match" mode="matching-solution">

The XPATH match on exercise needs to expand to the broader possibilities, probably something like exercise|&PROJECT-LIKE;|task, but I'm not sure if that is valid at this level of an XPATH or why it wasn't done initially.

@rbeezer
Copy link
Collaborator

rbeezer commented Oct 2, 2024

Being overly restrictive/cautious, I think. I would remove the exercise/ and it should (a) behave for task (and &PROJECT-LIKE) , and (b) not wreck anything else. I've tested (a), have not done a before/after diff for (b).

@dbrianwalton
Copy link
Contributor Author

If you get a resolution done this afternoon, feel free to just do it. I wouldn't have a chance to actually put together a PR and test until possibly tomorrow based on my current workload.

@rbeezer
Copy link
Collaborator

rbeezer commented Oct 2, 2024

Made the fix, and put your name on it. ;-) At 4c151d6 Thanks for being part of the bug-rapid-response team.

Added to the sample article under my name. Comprehensive testing indicates no collateral harm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants