Change to pass data.table v1.12.0 please #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
data.table v1.12.0 is about to go to CRAN and revdep checking shows one fail in SpaDES.core. I've checked this PR passes. The 6th column of
by=
here is"arguments"
which is typelist
which isn't supported by sorting/grouping/unique in data.table. It worked before because data.table didn't look at the type of the column until it needed to. In this case, the first few columns ofby=
were enough to establish the uniqueness and the subsequent columns weren't used. The new version of data.table works a bit differently and all the column types are now checked up-front.The status before this PR was :
Please could you update SpaDES.core on CRAN. Either in advance or after data.table is there is fine too.
Thanks, Matt