Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context tests; fix issue loading upstream task events #229

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Jul 12, 2024

The check for agent + task matches was overly generous - requiring both the agent match and the task match to fail to ignore an event, when in practice it's usually one or the other. Replaced the AND with an OR to fix.

@jlowin jlowin added the bug Something isn't working label Jul 12, 2024
@jlowin jlowin merged commit b08e3a1 into main Jul 12, 2024
3 checks passed
@jlowin jlowin deleted the test_context branch July 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant