Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable typescript-eslint recommended rules that overlap with TS checks. #118

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

collincchoy
Copy link
Contributor

@collincchoy collincchoy commented Apr 1, 2024

Removing these slow and unnecessary rules that overlap w/ TS checks. Recommended in typescript-eslint performance docs for eslint-plugin-import plugin - https://typescript-eslint.io/troubleshooting/performance-troubleshooting/#eslint-plugin-import

We recommend you do not use the following rules, as TypeScript provides the same checks as part of standard type checking:

import/named
import/namespace
import/default
import/no-named-as-default-member
import/no-unresolved (as long as you are using import over require)

import/namespace and import/no-unresolved are also seemingly slow.
image

@collincchoy collincchoy merged commit 4ccc10a into main Apr 1, 2024
@collincchoy collincchoy deleted the remove-ts-overlap-rules branch April 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants