Batch submit task #41
Conversation
There was a problem hiding this comment.
batch_submit looks good. I think it's important to also have the waiting functionality that's mentioned in #38. Can you also add a client_waiter task in this PR or in a follow up PR?
|
Perhaps another PR, and I think @mtconger97 might be interested in helping out with it! |
tests/conftest.py
Outdated
| @pytest.fixture(scope="session", autouse=True) | ||
| def prefect_db(): | ||
| with prefect_test_harness(): | ||
| yield | ||
|
|
There was a problem hiding this comment.
Why did you remove this fixture?
There was a problem hiding this comment.
I think it was crashing tests earlier (e.g. from prefect.utilities.testing import prefect_test_harness), but now I think it's not used since the tests are still passing?
There was a problem hiding this comment.
asyncio: mode=auto
collected 58 items
tests/test_batch.py . [ 1%]
tests/test_client_parameters.py .... [ 8%]
tests/test_s3.py ............... [ 34%]
tests/test_secrets_manager.py ...................................... [100%]
===================================================================================== 58 passed in 103.01s (0:01:43) =====================================================================================
There was a problem hiding this comment.
Based on the comments in #27 where it was added, it's a nice thing to have to spin up a temporary DB per test. I think we should leave it in and correct the import path (from prefect.test.utilities import prefect_test_harness).
Adds #38