Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

add regression test for dataclass as input to submitted tasks #130

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Mar 11, 2024

motivated by PrefectHQ/prefect#6905, this PR adds some tests to show we can in fact pass dataclass instances to tasks when using the DaskTaskRunner (as illustrated by the MRE in that issue) - at this time, it's not clear to be when this behavior was fixed.

this PR also updates some CI and removes some CI cruft

@zzstoatzz zzstoatzz requested a review from a team as a code owner March 11, 2024 18:52
@zzstoatzz zzstoatzz changed the title Test dataclass as input add regression test for dataclass as input to submitted tasks Mar 11, 2024
Copy link

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@zzstoatzz zzstoatzz merged commit 41e17fb into main Mar 11, 2024
7 checks passed
@zzstoatzz zzstoatzz deleted the test-dataclass-as-input branch March 11, 2024 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataclasses cannot be passed to a task if run with DaskTaskRunner
2 participants