Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Performs cruft update (#99)
Browse files Browse the repository at this point in the history
* Performs cruft update

* Fix static analyses

Co-authored-by: ahuang11 <andrew.h@prefect.io>
  • Loading branch information
desertaxle and ahuang11 authored Dec 6, 2022
1 parent 3796c1f commit 44e954b
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .cruft.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"template": "https://github.com/PrefectHQ/prefect-collection-template",
"commit": "e3d7ae506a6c84fdb78d2e74177833d625d72198",
"commit": "dabff0c99e3eb545d926ec6026bf8843e84eeb6a",
"checkout": null,
"context": {
"cookiecutter": {
Expand Down
42 changes: 19 additions & 23 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,28 @@
<!--
Thanks for opening a pull request to prefect-dbt 🎉!
<!-- Thanks for contributing 🎉! Please ensure the title neatly summarizes the proposed changes. -->

We've got a few requests to help us review contributions:
<!-- Overview -->

- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience.
- Run `pre-commit install && pre-commit run --all` for linting.
Happy engineering!
-->

<!-- Include an overview here -->

<!-- Link to issue -->
Closes #
Closes

### Example
<!--
Share an example of the change in action.
A code blurb is best. Changes to features should include an example that is executable by a new user.
<!-- A code blurb is best. Changes to features should include an example that is executable by a new user. -->

### Screenshots
<!--
Any relevant screenshots
- The updated docs page from `mkdocs serve`.
- Output from running the example.
- Service integration test results.
-->

### Checklist
<!-- These boxes may be checked after opening the pull request. -->

- [ ] This pull request references any related issue by including "Closes #<ISSUE_NUMBER>"
- If no issue exists and your change is not a small fix, please [create an issue](https://github.com/PrefectHQ/prefect-dbt/issues/new/choose) first.
- [ ] This pull request includes tests or only affects documentation.
- [ ] Summarized PR's changes in [CHANGELOG.md](https://github.com/PrefectHQ/prefect-dbt/blob/main/CHANGELOG.md)
- [ ] References any related issue by including "Closes #<Issue Number>" or "Closes <Issue URL>".
- If no issue exists and your change is not a small fix, please [create an issue](https://github.com/PrefectHQ/prefect-dbt/issues/new/choose) first.
- [ ] Includes tests or only affects documentation.
- [ ] Passes `pre-commit` checks.
- Run `pre-commit install && pre-commit run --all` locally for formatting and linting.
- [ ] Includes screenshots of documentation updates.
- Run `mkdocs serve` view documentation locally.
- [ ] Summarizes PR's changes in [CHANGELOG.md](https://github.com/PrefectHQ/prefect-dbt/blob/main/CHANGELOG.md)
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,11 @@ repos:
- id: interrogate
args: [-vv]
pass_filenames: false
- repo: https://github.com/fsouza/autoflake8
rev: v0.3.2
hooks:
- id: autoflake8
language_version: python3
args: [
'--in-place',
]
8 changes: 2 additions & 6 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Getting Started

Now that you've bootstrapped a project, follow the steps below to get started developing your Prefect Collection!

### Python setup

Requires an installation of Python 3.7+
Expand All @@ -10,12 +12,6 @@ We recommend using a Python virtual environment manager such as pipenv, conda or

### GitHub setup

Generate a Prefect Collection project in the terminal:

```bash
cookiecutter https://github.com/PrefectHQ/prefect-collection-template
```

Create a Git respoitory for the newly generated collection and create the first commit:

```bash
Expand Down
2 changes: 0 additions & 2 deletions prefect_dbt/cloud/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ def extract_developer_message(ex: HTTPStatusError) -> Optional[str]:
class DbtCloudAdministrativeApiCallFailed(Exception):
"""Raised when a call to dbt Cloud administrative API fails."""

pass


@task(
name="Call dbt Cloud administrative API endpoint",
Expand Down
14 changes: 14 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,24 @@ def dbt_cloud_credentials():

@pytest.fixture(scope="session", autouse=True)
def prefect_db():
"""
Sets up test harness for temporary DB during test runs.
"""
with prefect_test_harness():
yield


@pytest.fixture(autouse=True)
def reset_object_registry():
"""
Ensures each test has a clean object registry.
"""
from prefect.context import PrefectObjectRegistry

with PrefectObjectRegistry():
yield


@pytest.fixture
def dbt_cli_profile():
target_configs = TargetConfigs(
Expand Down

0 comments on commit 44e954b

Please sign in to comment.