This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Restrict target configs keys #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce (#109) * Adds metadata client * Enhances docstrings * Adds tests * Adds changelog entry
|
Not doing Postgres here because that requires a much larger effort to pivot towards the new SqlAlchemyConnector, and potentially breaking (or lots of deprecation to handle) |
|
Tests will fail until PrefectHQ/prefect-snowflake#58 is merged. |
desertaxle
reviewed
Jan 4, 2023
prefect_dbt/cli/configs/bigquery.py
Outdated
Comment on lines
89
to
90
| @sync_compatible | ||
| async def get_configs(self) -> Dict[str, Any]: | ||
| def get_configs(self) -> Dict[str, Any]: |
There was a problem hiding this comment.
Is this technically a breaking change? Would you see errors if you were previously awaiting this method?
There was a problem hiding this comment.
Yes this is a breaking change
desertaxle
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouples external collections blocks' fields from dbt configs (e.g. if a new field is added, won't inadvertently also add it to the dbt profile unless it's an expected key).
Also, user was experiencing issue with async so dropped the async. I don't think async matters much here anyways.
Closes #104 and #108
Example
Screenshots
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.mkdocs serveview documentation locally.