Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix save load roundtrip #115

Merged
merged 11 commits into from
Feb 1, 2023
Merged

Fix save load roundtrip #115

merged 11 commits into from
Feb 1, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 11, 2023

Upon loading DbtCliProfile, the original fields from the specialized TargetConfigs gets dropped. The following used to have a credentials field.

DbtCliProfile(name='bigbird', target='abc', target_configs=TargetConfigs(extras=None, type='bigquery', threads=20), global_configs=None)
Expected

Closes #114

Example

Screenshots

image

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ahuang11 ahuang11 requested a review from zzstoatzz January 11, 2023 20:07
@ahuang11 ahuang11 force-pushed the fix_save_load_roundtrip branch from b09fbc1 to 2d16c46 Compare February 1, 2023 03:44
@ahuang11 ahuang11 marked this pull request as ready for review February 1, 2023 03:57
@ahuang11 ahuang11 requested a review from a team February 1, 2023 03:57
ahuang11 and others added 2 commits February 1, 2023 09:29
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
@ahuang11 ahuang11 requested a review from desertaxle February 1, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetConfigs' credentials gets dropped upon loading a DbtCliProfile
2 participants