Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert string port to int port #132

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Convert string port to int port #132

merged 4 commits into from
Feb 21, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Feb 21, 2023

User reports "Version 0.3.0 creates an invalid dbt profile for postgres. Port value in the target config is set as string which fails dbt cli run. Profile is correct with version 0.2.7."

Closes #131

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ahuang11 ahuang11 marked this pull request as ready for review February 21, 2023 19:05
@ahuang11 ahuang11 requested a review from a team February 21, 2023 19:05
@zzstoatzz
Copy link
Contributor

looks like we're failing a test for DBTCoreOperation?

@ahuang11
Copy link
Contributor Author

Okay it should be fixed.

@ahuang11 ahuang11 merged commit 5822175 into main Feb 21, 2023
@desertaxle desertaxle deleted the fix_port_value branch February 21, 2023 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres port set as string in profiles.yml
3 participants