Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade use of attr inheritance to the options api #1527

Open
znicholasbrown opened this issue Nov 21, 2024 · 0 comments
Open

Upgrade use of attr inheritance to the options api #1527

znicholasbrown opened this issue Nov 21, 2024 · 0 comments

Comments

@znicholasbrown
Copy link
Contributor

We're currently blocked from upgrading to Vue 3.5+ for this project cause of our use of:

export default {
  inheritAttrs: false,
  expose: []
}

everywhere.

We need to update all our components to use: defineOptions({ inheritAttrs: false }) and defineExpose() (if we need to expose anything, otherwise we can omit)

See failed job: https://github.com/PrefectHQ/prefect-design/actions/runs/11962658374/job/33351536977

znicholasbrown added a commit that referenced this issue Nov 21, 2024
…e peer dep, see #1527Revert vue peer dep, see #1527Revert vue peer dep, see #1527Revert vue peer dep, see #1527Revert vue peer dep, see #1527Revert vue peer dep, see #1527Revert vue peer dep, see #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant