Fix: Allow editing of long strings in the PCodeInput component #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zhen0
commented
Aug 1, 2023
zhen0
changed the title
zhen0
requested review from
pleek91,
znicholasbrown and
brandonreid
as code owners
pleek91
approved these changes
Aug 18, 2023
Co-authored-by: pleek91 <craig@prefect.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had reports of a bug in our code input. The video before shows the issue - I can't click into a long string input:
https://github.com/PrefectHQ/prefect-design/assets/40272060/d4c4a2a8-79ac-4abf-af23-ced7ac1a2369
This PR refactors how we set the width of the textarea in the PCodeInput to set it according to the width of the input/the width of the sibling view-container.
Screen.Recording.2023-08-01.at.3.10.04.PM.mov