-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
…refect-gcp into bianca-worker-guide
LGTM! Co-authored-by: Taylor Curran <68969861+taylor-curran@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome! just a couple wording suggestions
1. `prefect.deployments.steps.run_shell_script` : runs a shell command which configures Docker to authenticate with GCR using your Google Cloud credentials. | ||
2. `prefect_docker.deployments.steps.build_docker_image` : builds a Docker image automatically which uses the name and tag chosen previously. | ||
|
||
!!!Warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful! nice inclusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work @biancaines! Love how thorough the guide is! I left some comments, mostly small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff @biancaines ! Great attention to detail and helpful tone and content!
|
||
3. Integration with Google Cloud Services: Google Cloud Run easily integrates with other Google Cloud services, such as Google Cloud Storage, Google Cloud Pub/Sub, and Google Cloud Build. This enables you to build end-to-end data pipelines utilizing a variety of services. | ||
|
||
4. Portability: Since Cloud Run uses container images, you can develop your pipelines locally using Docker and then deploy them on Google Cloud Run without significant modifications. This portability allows you to run the same pipeline in different environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
docs/gcp-worker-guide.md
Outdated
Find your deployment in the UI, and hit the *Quick Run* button. | ||
You have now successfully submitted a flow run to your Cloud Run worker! | ||
If you used the flow script provided in this guide, check the artifacts tab for the flow run once it completes. | ||
You'll have a nice little weather report waiting for you there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this - could add a "Hope your day is sunny!" or something to the end.
I suggest a quick recap and next steps sections at the end. Maybe direct to the Serverless Work Pools page in the Prefect docs as something they might be interested in.
Co-authored-by: nate nowack <nate@prefect.io>
Co-authored-by: nate nowack <nate@prefect.io>
Co-authored-by: nate nowack <nate@prefect.io>
Co-authored-by: nate nowack <nate@prefect.io>
Co-authored-by: nate nowack <nate@prefect.io>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Emil Christensen <EmilRex@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
…ade formatting changes, swapping square brackets [] for carrots <> wherever a value needs to be swapped out. Added recap, and next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I made minor copy-edit suggestions for consistency with other docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
The next prompt will ask if you'd like to allow unauthentiated invocations to your worker. For this guide, you can select "No". | ||
|
||
After a few seconds, you'll be able to see your new `prefect-worker` service by navigating to the Cloud Run page of your Google Cloud console. Additionally, you should be able to see a record of this worker in the Prefect UI on the work pool's page by navigating to the `Worker` tab. | ||
Let's not leave our worker hanging, it's time to give it a job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol get a job worker
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: kevingrismore <146098880+kevingrismore@users.noreply.github.com>
…refect-gcp into bianca-worker-guide
…refect-gcp into bianca-worker-guide
```bash | ||
gcloud iam service-accounts keys create my_key.json \ | ||
--serviceAccount:<SERVICE_ACCOUNT_NAME>@<PROJECT_ID>.iam.gserviceaccount.com | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biancaines Hi, I am trying out the guide at the moment to setup prefect with cloud run for my org. Thank you so much, it is such a valuable resource! 😊
This command however did not work for me, because --serviceAccount
is not recognized as a command:
ERROR: (gcloud.iam.service-accounts.keys.create) unrecognized arguments: --serviceAccount:<my-account-name>@<my-project>.iam.gserviceaccount.com
With the help of the GCP Documentation here, the following command worked for me:
gcloud iam service-accounts keys create my_key.json \
--iam-account=<SERVICE_ACCOUNT_NAME>@<PROJECT_ID>.iam.gserviceaccount.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bjarneschroeder ! Thank you for you kind words, and for providing the command you used! I'll give this a try as well, and either swap out the command or create a note that it can be used as an alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌
Closes
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.