Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Japerry911/fix/cloud run v2 worker def cmd switch #233

Conversation

japerry911
Copy link
Contributor

@japerry911 japerry911 commented Dec 4, 2023

Update the Cloud Run v2 Worker, so it utilizes BaseJobConfiguration._base_flow_run_command for default command logic.

Closes #232

Example

self.job_body["template"]["template"]["containers"][0][
     "command"
] = shlex.split(self._base_flow_run_command())

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@japerry911 japerry911 requested a review from a team as a code owner December 4, 2023 21:50
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@desertaxle desertaxle merged commit cbca902 into PrefectHQ:main Dec 5, 2023
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Prefect Command for Cloud Run V2 Worker not up-to-date
2 participants