Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

update Cloud Run timeout parameters #256

Closed
wants to merge 2 commits into from

Conversation

jeremy-thomas-roc
Copy link
Contributor

We are still using agents for our jobs and need this timeout increased to match Google's job specs.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.

@jeremy-thomas-roc jeremy-thomas-roc requested a review from a team as a code owner March 18, 2024 19:04
@jeremy-thomas-roc
Copy link
Contributor Author

@desertaxle this is something that my team could really use to be merged before agents are deprecated, as we do not see a path to upgrade to workers as viable. can I get a review on this?

@desertaxle
Copy link
Member

Thanks for the PR @jeremy-thomas-roc! The reason the timeout for the CloudRun infrastructure block is capped at 1 hour is because that block uses the Cloud Run V1 API which has a max timeout of 1 hour. Unfortunately, updating the max on our end will not increase the timeout limit above an hour.

Do you mind sharing why an upgrade to workers is not viable for your team? We might be able to make enhancements to the Cloud Run workers that would make an upgrade viable.

@jeremy-thomas-roc
Copy link
Contributor Author

Thanks for the PR @jeremy-thomas-roc! The reason the timeout for the CloudRun infrastructure block is capped at 1 hour is because that block uses the Cloud Run V1 API which has a max timeout of 1 hour. Unfortunately, updating the max on our end will not increase the timeout limit above an hour.

Do you mind sharing why an upgrade to workers is not viable for your team? We might be able to make enhancements to the Cloud Run workers that would make an upgrade viable.

@desertaxle I see, that is unfortunate. We will have to continue using Vertex for our backend for the foreseeable future then.

I have detailed our issues with workers in a thread on Discourse: https://discourse.prefect.io/t/switching-from-agents-to-workers-in-a-monorepo/4024

@desertaxle
Copy link
Member

Thank you for your willingness to contribute to prefect-gcp! The code for this library has been moved to https://github.com/PrefectHQ/prefect/tree/main/src/integrations/prefect-gcp. Please reopen this PR there if this functionality is still needed!

@desertaxle desertaxle closed this Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants