This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update GcpCredentials to use SecretDict for service_account_info #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 26, 2022 17:28
5 tasks
ahuang11
changed the title
desertaxle
previously approved these changes
Dec 19, 2022
|
This works now: |
desertaxle
approved these changes
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73 by making use of SecretDict to obfuscate GcpCredentials.service_account_info. This is a breaking change.
Example
Screenshots
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.mkdocs serveview documentation locally.