Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix type hints for **kwargs to match PEP-484 #98

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

JohnLemmonMedely
Copy link
Contributor

@JohnLemmonMedely JohnLemmonMedely commented Dec 12, 2023

I just learned this today as I was figuring out why my IDE was flagging the type hints as wrong but kwargs should be hinted as the value in the dict and not as a dict itself. See PEP-484.

Closes

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@JohnLemmonMedely JohnLemmonMedely requested a review from a team as a code owner December 12, 2023 15:55
@JohnLemmonMedely
Copy link
Contributor Author

@desertaxle I'm hoping to merge this in a get a new release so we don't have to depend on my fork anymore. Is that doable this week?

Copy link
Contributor

@urimandujano urimandujano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JohnLemmonMedely, I'm sorry for the delay getting this reviewed and merged. This is a good find! I'll make sure to include this in the next release (which will likely be in early January).

@urimandujano urimandujano merged commit 4e8dd82 into PrefectHQ:main Dec 26, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants