-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[UI v2] feat: Loads data and url state to concurrency limit route for…
… UX to consume
- Loading branch information
1 parent
9ff7d0b
commit 35d8240
Showing
6 changed files
with
106 additions
and
40 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,81 @@ | ||
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs"; | ||
import { TAB_OPTIONS, TabOptions } from "./concurrency-constants"; | ||
import { TabOptions } from "@/routes/concurrency-limits"; | ||
import { getRouteApi } from "@tanstack/react-router"; | ||
|
||
const routeApi = getRouteApi("/concurrency-limits"); | ||
|
||
type TabOptionValues = { | ||
/** Value of search value in url */ | ||
tabSearchValue: TabOptions; | ||
/** Display value for the UI */ | ||
displayValue: string; | ||
}; | ||
|
||
/** Maps url tab option to visual name */ | ||
const TAB_OPTIONS: Record<TabOptions, TabOptionValues> = { | ||
global: { | ||
tabSearchValue: "global", | ||
displayValue: "Global", | ||
}, | ||
["task-run"]: { | ||
tabSearchValue: "task-run", | ||
displayValue: "Task Run", | ||
}, | ||
} as const; | ||
|
||
type Props = { | ||
globalView: React.ReactNode; | ||
onValueChange: (value: TabOptions) => void; | ||
taskRunView: React.ReactNode; | ||
value: TabOptions; | ||
}; | ||
|
||
// TODO: Move Tabs for navigation to a generic styled component | ||
|
||
export const ConcurrencyTabs = ({ | ||
globalView, | ||
onValueChange, | ||
taskRunView, | ||
value, | ||
}: Props): JSX.Element => { | ||
const { tab } = routeApi.useSearch(); | ||
const navigate = routeApi.useNavigate(); | ||
|
||
return ( | ||
<Tabs | ||
defaultValue="Global" | ||
className="w-[400px]" | ||
value={value} | ||
onValueChange={(value) => onValueChange(value as TabOptions)} | ||
> | ||
<Tabs defaultValue="Global" value={tab}> | ||
<TabsList className="grid w-full grid-cols-2"> | ||
<TabsTrigger value="Global">{TAB_OPTIONS.Global}</TabsTrigger> | ||
<TabsTrigger value="Task Run">{TAB_OPTIONS["Task Run"]}</TabsTrigger> | ||
<TabsTrigger | ||
value={TAB_OPTIONS.global.tabSearchValue} | ||
onClick={() => { | ||
void navigate({ | ||
to: "/concurrency-limits", | ||
search: (prev) => ({ | ||
...prev, | ||
tab: TAB_OPTIONS.global.tabSearchValue, | ||
}), | ||
}); | ||
}} | ||
> | ||
{TAB_OPTIONS.global.displayValue} | ||
</TabsTrigger> | ||
|
||
<TabsTrigger | ||
value={TAB_OPTIONS["task-run"].tabSearchValue} | ||
onClick={() => { | ||
void navigate({ | ||
to: "/concurrency-limits", | ||
search: (prev) => ({ | ||
...prev, | ||
tab: TAB_OPTIONS["task-run"].tabSearchValue, | ||
}), | ||
}); | ||
}} | ||
> | ||
{TAB_OPTIONS["task-run"].displayValue} | ||
</TabsTrigger> | ||
</TabsList> | ||
<TabsContent value={TAB_OPTIONS.Global}>{globalView}</TabsContent> | ||
<TabsContent value={TAB_OPTIONS["Task Run"]}>{taskRunView}</TabsContent> | ||
<TabsContent value={TAB_OPTIONS.global.tabSearchValue}> | ||
{globalView} | ||
</TabsContent> | ||
<TabsContent value={TAB_OPTIONS["task-run"].tabSearchValue}> | ||
{taskRunView} | ||
</TabsContent> | ||
</Tabs> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,24 @@ | ||
import { ConcurrencyPage } from "@/components/concurrency/concurrency-page"; | ||
import { useListGlobalConcurrencyLimits } from "@/hooks/global-concurrency-limits"; | ||
import { createFileRoute } from "@tanstack/react-router"; | ||
import { zodSearchValidator } from "@tanstack/router-zod-adapter"; | ||
import { z } from "zod"; | ||
|
||
import { ConcurrencyPage } from "@/components/concurrency/concurrency-page"; | ||
/** | ||
* Schema for validating URL search parameters for the Concurrency Limits page. | ||
* @property {'Global' | 'Task_Run'} tab used designate which tab view to display | ||
*/ | ||
const searchParams = z | ||
.object({ | ||
tab: z.enum(["global", "task-run"]).default("global"), | ||
}) | ||
.strict(); | ||
|
||
export type TabOptions = z.infer<typeof searchParams>["tab"]; | ||
|
||
export const Route = createFileRoute("/concurrency-limits")({ | ||
component: RouteComponent, | ||
validateSearch: zodSearchValidator(searchParams), | ||
component: ConcurrencyPage, | ||
wrapInSuspense: true, | ||
loader: useListGlobalConcurrencyLimits.loader, | ||
}); | ||
|
||
function RouteComponent() { | ||
return <ConcurrencyPage />; | ||
} |