-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent workers from running flow runs scheduled for in process retry #15482
base: main
Are you sure you want to change the base?
Conversation
@zzstoatzz has pointed out that this change will break flow retries from the UI since it uses the Edit: This was for the initial implementation that used |
Allows server to distinguish which `AwaitingRetry` flows should be returned when retrieving scheduled flow runs
CodSpeed Performance ReportMerging #15482 will not alter performanceComparing Summary
|
AwaitingRetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 lgtm
Hi all. Is there a plan to get this into a release soon? This issue has been a major pain for us at CU Boulder and we would love to see this fix deployed. Thank you! |
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
This PR adds the
retry_type
field toFlowRunPolicy,
so the server can determine if a flow will be retried via an already running process or needs to be rescheduled. Automatic retries will haveretry_type
set toin_process
via the existingRetryFailedFlows
orchestration policy. The query to get scheduled flow runs has been updated to filter out flow runs that are inAwaitingRetry
but will be retried via an existing process. When transition out of a terminal state into aSCHEDULED
state (i.e. manual retries) theretry_type
will be set toreschedule
and will be given to workers for execution by the server.Closes #15458