Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] dev: Adds tanstack query eslint rules and updates docs for variable mutations #16157

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Nov 29, 2024

  1. Adds tanstack query eslint rule which ensures variables being passed into queryFn are also queryKey dependencies. Details here: https://tanstack.com/query/v5/docs/eslint/eslint-plugin-query
  2. Updates docs for useMutation from previous PR [UI v2] Move delete variable mutation to variable hooks module #16141

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Followup from #16155
Related to #15512

@devinvillarosa devinvillarosa force-pushed the add-eslint-tanstack-query branch from 7112a9b to ad07c34 Compare November 29, 2024 21:52
@devinvillarosa devinvillarosa marked this pull request as ready for review November 29, 2024 21:54
@devinvillarosa devinvillarosa merged commit 1aa0186 into main Nov 30, 2024
13 checks passed
@devinvillarosa devinvillarosa deleted the add-eslint-tanstack-query branch November 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants