-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typing] prefect.concurrency #16441
base: main
Are you sure you want to change the base?
[typing] prefect.concurrency #16441
Conversation
695d8ff
to
32643b2
Compare
32643b2
to
698e585
Compare
CodSpeed Performance ReportMerging #16441 will not alter performanceComparing Summary
|
853011a
to
f99ed16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! holding just for that ruff question and to give @desertaxle a chance to peek at that client context change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realizing that prefect.concurrency.asyncio
-> prefect.concurrency._asyncio
etc would be a breaking change from an imports perspective, which I think we'd have to avoid
f99ed16
to
0003cf9
Compare
Darn. I'll put the public names from that module back then; until the client flow test failed I wasn't even aware there were other import locations outside of the concurrency package. |
0003cf9
to
d88e240
Compare
All the public |
128fe58
to
792e706
Compare
1c657e2
to
c6bb5d5
Compare
c6bb5d5
to
3951dcf
Compare
References #16292