Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Adds msw addon for storybook #16625

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 6, 2025

  1. Adds msw addon for storybook. Re-uses our existing handlers
  2. Adds toastDecorator to components that has mutation callbacks
Screen.Recording.2025-01-06.at.10.00.53.AM.mov
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 6, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to autogenerate file using msw cli for it to work with storybook

ui-v2/public/mockServiceWorker.js Dismissed Show dismissed Hide dismissed
@devinvillarosa devinvillarosa marked this pull request as ready for review January 6, 2025 18:07
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was just about to need this too! We'll need to remember to exclude the generated mock service worker from the build once the new UI is ready to start being packaged with the library.

@devinvillarosa devinvillarosa merged commit 8b8eea2 into main Jan 6, 2025
17 checks passed
@devinvillarosa devinvillarosa deleted the add-storybook-msw branch January 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants