Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Updates automation wizard action steps to be part of the automation wizard #16722

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 15, 2025

  1. Updates Automation wizard schema to include actions, name, and description.
  2. Elevates the Form container and state to a higher level.
  3. Updates tests to now be wrapped with a Form container
Screen.Recording.2025-01-14.at.5.23.37.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 15, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review January 15, 2025 01:31
const WIZARD_STEPS_MAP = {
Trigger: { render: () => <div>TODO</div>, trigger: async () => {} },
Actions: {
render: () => <ActionsStep />,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic note, but do you plan on passing props to these components? If not, you could declare it directly:

Suggested change
render: () => <ActionsStep />,
Component: <ActionsStep />,

I think using Component as the key makes it easier to see at a glance that a child component is being used on line 63.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll make the update.
Reading the docs, it seems like render makes more sense if we had more stories to be used and share with the default export

@devinvillarosa devinvillarosa merged commit 0ab0bd6 into main Jan 15, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the automation-wizard branch January 15, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants