Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] feat: Begins logic for creating UX based on an action type #16752

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 16, 2025

  1. Begins writing components for the UX on what an action does. First starting with the simple actions and actions that are inferred
  2. Writes a storybook to help display the different UX based on the action
  3. Adds improvement to remove redundant ids when joining deployments and flows

Will add tests once things are more complete (and compoennt pattern is proven)

Screen.Recording.2025-01-16.at.1.57.22.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 16, 2025
@devinvillarosa devinvillarosa force-pushed the parse-automation-action-description branch from 6149a58 to 3934f19 Compare January 16, 2025 22:11
@devinvillarosa devinvillarosa marked this pull request as ready for review January 16, 2025 22:12
@devinvillarosa devinvillarosa force-pushed the parse-automation-action-description branch 2 times, most recently from 403a6c4 to 7fcb731 Compare January 17, 2025 05:26
@devinvillarosa devinvillarosa force-pushed the parse-automation-action-description branch from 7fcb731 to abec03c Compare January 17, 2025 05:50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this optimization so that the joins for deployment flows removes repeated ids

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit 16e85ce into main Jan 17, 2025
9 checks passed
@devinvillarosa devinvillarosa deleted the parse-automation-action-description branch January 17, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants