Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all typing errors in prefect.runner.runner #16797

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix all typing errors in prefect.runner.runner #16797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/prefect/client/orchestration/_deployments/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,8 +1031,8 @@ async def get_scheduled_flow_runs_for_deployments(
deployment_ids: list["UUID"],
scheduled_before: "datetime.datetime | None" = None,
limit: int | None = None,
) -> list["FlowRunResponse"]:
from prefect.client.schemas.responses import FlowRunResponse
) -> list["FlowRun"]:
from prefect.client.schemas.objects import FlowRun

body: dict[str, Any] = dict(deployment_ids=[str(id) for id in deployment_ids])
if scheduled_before:
Expand All @@ -1046,7 +1046,7 @@ async def get_scheduled_flow_runs_for_deployments(
json=body,
)

return FlowRunResponse.model_validate_list(response.json())
return FlowRun.model_validate_list(response.json())

async def create_flow_run_from_deployment(
self,
Expand Down
2 changes: 1 addition & 1 deletion src/prefect/flows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ def __call__(
import logging

from prefect.client.orchestration import PrefectClient
from prefect.client.schemas.objects import FlowRun
from prefect.client.types.flexible_schedule_list import FlexibleScheduleList
from prefect.deployments.runner import RunnerDeployment
from prefect.flows import FlowRun
from prefect.runner.storage import RunnerStorage

logger: "logging.Logger" = get_logger("flows")
Expand Down
3 changes: 1 addition & 2 deletions src/prefect/logging/loggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
LoggingAdapter = logging.LoggerAdapter

if TYPE_CHECKING:
from prefect.client.schemas import FlowRun as ClientFlowRun
from prefect.client.schemas.objects import FlowRun, TaskRun
from prefect.context import RunContext
from prefect.flows import Flow
Expand Down Expand Up @@ -164,7 +163,7 @@ def get_run_logger(


def flow_run_logger(
flow_run: Union["FlowRun", "ClientFlowRun"],
flow_run: "FlowRun",
flow: Optional["Flow[Any, Any]"] = None,
**kwargs: str,
) -> PrefectLogAdapter:
Expand Down
Loading
Loading