Devan/eng 1247 artifactsartifactid

[devangrose]

In draft until dependent is merged

Add detail page for each type of data

Checklist

• This pull request references any related issue by including "closes <link to issue>"
  • If no issue exists and your change is not a small fix, please create an issue first.
• If this pull request adds new functionality, it includes unit tests that cover the changes
• If this pull request removes docs files, it includes redirect settings in mint.json.
• If this pull request adds functions or classes, it includes helpful docstrings.

[devinvillarosa]

Gut feeling, it seems a bit odd that we need to do artifact.data as string to override the typings in the UI layer.
If artifact.data is expected (even with wrongful typing from openAPI), can't we just add an assert expecting this type to be a string in the api / hook layer?

[devinvillarosa]

I think TS thinks artifact might not be truthy because of typing from getQueryService.
On the hook layer, can you assert that res.data is truthy

[devangrose]

Gut feeling, it seems a bit odd that we need to do artifact.data as string to override the typings in the UI layer. If artifact.data is expected (even with wrongful typing from openAPI), can't we just add an assert expecting this type to be a string in the api / hook layer?

Smart - I'll put that in

[devangrose]

Another reply: we use number values for progress artifacts - which kind of leads me to leave typecasting in the UI

[devinvillarosa]

Another reply: we use number values for progress artifacts - which kind of leads me to leave typecasting in the UI

hmm, would it make sense to have the component to just accept both number and string types then?

[devangrose]

I think my commit here fixed most of it: ff7dd66

I think that we should keep the separate number and string types, I get a little nervous when directly recasting primitives from the backend. I would be up for seeing if the number can be cast as a string on the backend though and then unifying the type

[devinvillarosa]

LGTM.

Just one minor suggestion, and a nit comment